You are viewing a single thread.
View all comments
14 points

oh of course there is

https://www.npmjs.com/package/is-even

(do take a look at the download stats)

permalink
report
reply
13 points
*

And that isn’t even the worst thing about it…

The implementation looks like this:

function isEven(i) {
  return !isOdd(i);
};

And yes, is-odd is a dependency that in turn depends on is-number

permalink
report
parent
reply
7 points
*

Can’t you just

If (number % 2 == 0){return true}

permalink
report
parent
reply
12 points

return number % 2 === 0

permalink
report
parent
reply
1 point

Yeah, that’s even simpler

permalink
report
parent
reply
6 points

but what if number isn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate that number is actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.

That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.

permalink
report
parent
reply
1 point

ah the joys of loosely typed languages

permalink
report
parent
reply
1 point

That would already cause an exception when calling the function because it has int number in the parameters

permalink
report
parent
reply
5 points

yup, which is why I find the download stats truly horrifying

permalink
report
parent
reply
5 points

no

permalink
report
parent
reply
2 points

ok

permalink
report
parent
reply
7 points
*

“If it’s not an npm package it’s impossible”

- JS devs, probably

permalink
report
parent
reply
5 points

That’s a lot of downloads

permalink
report
parent
reply