You are viewing a single thread.
View all comments View context
-2 points

What exactly do you think discard means?

permalink
report
parent
reply
69 points

“Changes” are not the same thing as “files”.

I’d expect that files that are not in version control would not be touched.

permalink
report
parent
reply
3 points
*

“Changes” encompass more than you think. Creating / Deleting files are also changes, not just edits to a file.

  • If the change is an edit to a tracked file, “Discard Changes” will reverse the edit.
  • If the change is deleting a tracked file, “Discard Changes” will restore it back.
  • If the change is a new untracked file, “Discard Changes” will remove it as intended.

It can also be all of them at the same time, which is why VSCode uses “Changes” instead of “Files”.

permalink
report
parent
reply
8 points

If the change is a new untracked file

Wasn’t the issue that it deleted a bunch of preexisting untracked files? So old untracked files.

permalink
report
parent
reply
25 points

And the terminology is misleading, resulting in problems. shrug.

permalink
report
parent
reply
11 points
*

Apparently, it means changes to the directory structure and what files are in them, not changes within the files themselves. It really ought to be more clear about this.

permalink
report
parent
reply
3 points

It means both.

permalink
report
parent
reply
4 points
*

Yeah. They did substantially modify the message to make it much clearer, thankfully.

permalink
report
parent
reply
13 points
*

Yeah. That’s discussed in more detail in the code change that resulted from the issue report.

It’s a ballsy move by the VSCode team to not only include git clean but to keep it after numerous issue reports.

As others discussed in that thread, git clean has no business being offered in a graphical menu where a git novice may find it.

That said, I do think the expanded warning mesage they added addresses the issue by calling out that whatever git may think, the user is about to lose some files.

permalink
report
parent
reply

Programmer Humor

!programmer_humor@programming.dev

Create post

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

  • Keep content in english
  • No advertisements
  • Posts must be related to programming or programmer topics

Community stats

  • 5.3K

    Monthly active users

  • 1K

    Posts

  • 38K

    Comments