Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don’t mean professionally, just from like-minded individuals.

6 points
*

There was something like that on Reddit but I can’t remember the sub. I haven’t seen one here. The best way to get reviews of open source is via contributions to larger projects. That of course doesn’t answer your question directly but is worth noting.

I’d recommend joining some discord or matrix servers for the language you work in or likeminded folk. They tend to have channels for that, and some have really helpful communities.

eta: I just checked my local instance and saw a community with very few subs and zero posts called /c/reviewmycode. Somebody has to post first.

permalink
report
reply
1 point

It is quite empty indeed 🤔 !reviewmycode@lemmy.world

permalink
report
parent
reply
72 points

This is not an answer to your question but it’s tangentially related.

Someone I greatly respected ran an open-source project with the policy of merge everything. Completely flip this idea of carefully review, debate and revise every PR. His theory was that it helps to build an open community, and if something breaks someone else will revert that commit. He says that the main branch was almost always stable, a massive improvement to how it was run previously. He passed several years ago and for some reason this reminded me of him.

I guess what I’m trying to say is if you get something out there that people find useful, the code will be looked at. It doesn’t help you if you’re looking for someone to collaborate sorry.

permalink
report
reply
33 points

This is how you get supply chain attacks.

permalink
report
parent
reply
13 points

Yes it is. The code is in Bitcoin Core so there’s a non-zero chance you win at life if you want to try.

permalink
report
parent
reply
11 points

That’s Wikipedia’s approach, arguably one of the most successful “open source” projects in history - certainly not without its problems, but overall it’s pretty great

permalink
report
parent
reply
17 points
*

There is a very effective approach (34:00), that big companies like cloudflare use, to ship a product in a fast and quality way. It bears parallels to what you are describing. In essence engineers should not get hung up in the details to trying to solve everything.

  1. Just build a proof of concept
  2. Discard the prototype no matter what and start from scratch keeping the initial feedback in mind
  3. Build something internally that you yourself will use
  4. Only once something is good enough and is used internally, then release it to beta.

So that tedious process in trying to flush out all the details before seeing a product (or open source effort) working end to end, might be premature before having the full picture.

permalink
report
parent
reply
3 points

This is for 0mq right? I remember reading Pieter Hintjens about this realization he had over a long time of developing 0mq.

permalink
report
parent
reply
7 points

Yes that’s right. I was only just transitioning into adulthood and Pieter mentored me and profoundly changed how I view many things. It wasn’t just zeromq but that was the main thing. I still keep his books at hand on my bookshelf. His death impacted me greatly.

permalink
report
parent
reply
4 points

I’ve actually found his blog where he talks about this “optimistic merge”

http://hintjens.com/blog:106

permalink
report
parent
reply
4 points

There’s a number of them as the idea grows. See also the C4 process RFC

permalink
report
parent
reply
3 points

See also the C4 process RFC

What an unfortunate name.

https://c4model.com/

permalink
report
parent
reply
2 points

mbin (fork of kbin) is currently trying to implement the process.

permalink
report
parent
reply
13 points

I would totally get in on that. Seems almost like a fun OS project itself. Like a volunteer hub type site to just seek reviews

permalink
report
reply
-5 points
Removed by mod
permalink
report
reply
-4 points
Removed by mod
permalink
report
parent
reply
-6 points
Removed by mod
permalink
report
reply

Programming

!programming@programming.dev

Create post

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person’s post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you’re posting long videos try to add in some form of tldr for those who don’t want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



Community stats

  • 3.5K

    Monthly active users

  • 1.6K

    Posts

  • 26K

    Comments